From 8797b8cd96d11231123b9104deedbb3fee82bac3 Mon Sep 17 00:00:00 2001
From: MrWaradana <muhammadridhowaradana@gmail.com>
Date: Tue, 10 Feb 2026 13:10:03 +0700
Subject: [PATCH] feat: Enhance logging by defaulting request ID to SYSTEM,
 filtering internal attributes, and adding request lifecycle logs in the
 middleware.

---
 src/__pycache__/logging.cpython-311.pyc | Bin 4824 -> 4872 bytes
 src/__pycache__/main.cpython-311.pyc    | Bin 4967 -> 5506 bytes
 src/logging.py                          |   7 ++++---
 src/main.py                             |   3 +++
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/__pycache__/logging.cpython-311.pyc b/src/__pycache__/logging.cpython-311.pyc
index c8d8b12287d4437ec4a22aef0554a79ca10f7fca..20fbd2649386f794a304a4b7adba2e58102d8176 100644
GIT binary patch
delta 491
zcmZXO%_~G<6vpQm_hYW^9U~)5@-;(3MkwD44P!G1C51_IUt`L+*L&}Xlr34&*(n<v
z%8Dr#{sfVQukJr!V=>Cg%KJ{FIE!DW=Q-y*=Owh;pq;3y;$n4pvzKZvKG!<j5Xla?
z5kwR8LS4Y;!YGJXEkr$1Kbu>2=`tF^D|m25Yzr!5w1BBi;Alx=$0=FM5X+9I^iSw@
z#Hrb->ERe2iyKgZ0V$w4f|W2#LPKna*5iQGSXRSYM>46AAeQAw-xqLAs)isQNQ0`H
zFjfp2PcwTliMLV=+A$ypMtk_8!ct>-htQV%QH~%7&u|J1%Msa(nbK(&7raXbO)uKR
z8wq0CDPxuP;<lWIMtqYu;SrZSPr`j=_*BMzWx*#_Dmm8=cD0;_XUa9qW3s5v-zk*m
zTz`?hD%x?2<2-%>Bi=OB;)ORXWSB6Qef182pKve6F~kw&7{?x8q-L78lN>68;~B|6
nY7<H;xR}8sUlnZOwePOA8(8*#>_;C;L+{-9_;uIuvZU?{Z0v~?

delta 464
zcmeBByP?XroR^o20SK0F@5=1u-^gdo%;>P$iFq<3Qwq!E+br&ktdo^l-8tE8fNC-r
zQrIUKvp#3!m>kWf&&WBsn@xK1I<^XBF`(ov=G@}+TP%r1>BYBL@)C1XZ?WbUrzRH{
zsQ@L5lqLtTtMkf()Ug*7<tL{W7f<eGmuFO-yq4W=@-KGp6n&5!S7LEVW^QU#eqQP=
z&dlQcwEUvn#F8R2uv~g-i7!xJVtQ(kHrPxMp$sBGR@`FBFTTYFR8x?dQe*@Y;D_jT
ztw>HSD9OyvD>9$Fk|UQ<ZL&CLCF6z36FIL<&f$s^WR>FjzyKpU_&)GVzRk6pF>>;B
zZfj9vR*4S`=)~sd-0jS4-XM#8CYSK%GAc}d#Bab_2o#9kEG}TnD4Gb8^8^ugAi^0$
zcu&q0bWsQZG5tUUFOay!=?3;-NorA%BuKDu@>xMy#`4Lp1<&c4GXm|#Bqq3D5mEgJ
OlK6s<Et&jGNC^NqWP|Sj

diff --git a/src/__pycache__/main.cpython-311.pyc b/src/__pycache__/main.cpython-311.pyc
index 33c1c5f53626d9c18a0f465ae850a76d103180ed..e7365addd0b79f7d3356f3c5df8b69dc7f303aa5 100644
GIT binary patch
delta 1181
zcmbVKT}TvB6h1SvKX-QA^=CIVLzwWV%v6LTe^+etw?C*Q>1kMYMq68F*1NN4rU~}u
zOTncl5tOWqA}o6-uqUgRURGE_27HVj+lauVhwiw|Zdy+r&OP`1eCKfP$NgMAQ|o!;
zcDsPe%7@uVu;96;*CFsUyiL!yj~od(B)7w?XJo-f7Fn+sWM&eE?N)XUWR^&%xMdFJ
zZ4ViMC-h{50lm=j0ra9jd|%Fg%8^fws%F8;NO_jGr@PF`(n))}1I{WT*X<#3=P{4|
z*WNuK+a?{u`PLY^F1vqSHCO?<XdwV90ryNf_sl9ZIhY37u2<!7lg_=9hP_sevg6RR
zgaGVE{)@CprwlW!3{%cq&M{^T#<{C7#_&K{|NTr4z;KqO1)sSR@uTw69D)KUC?i=w
z<$)|s|I=Phz962dB|p&NY3GHBqCPdOjYQNT5i6q!C9b!KJB(Pv7<@de#gxH>8lLc8
z%9KQkj71e)kz2%x0xLNfibQuaoLDE;6dPPz$Jj=f#<kQKTvQt}Y!P)(GaMs|eod1N
zE`g(%10c<OL%k5!LwX`Eg*90*_^$D=64N7^YS<NwHEh`Q8!^Q|lB9-46iFhOzc2LB
zxh?d>S(b>dqjhe3;}#O`pjnhG>{}RGQt3r?W$fk6)Ty3Kuz~ths6UDN$ywL+=`6f`
zVLWxDHCfnBbp!cR$e-NR?JdEV2G(AdGiDDz%O{IYKL{=#UL05&NL8Jr5!E*puR^b@
z*Qzto1`4E5Ac+E-p8UJPBs#cFC2gm}%$ozggH5}LU${cr1hwHfeaN!_1R7wyp6PbO
zdV{MAxb@~v_Dn1Hw$)C9cfirYdv~X+r-W<@FT9<!2X~tcP!>THMchl~^UCb!Xf&|8
zmUoXmggZ>k3DdNh#{B077mCGj6B*6F+-P!$O}ycWsNrZrRwS$?bOk>KeBP|}QnQ2F
sMl?AQRs48#^?UwLwxX2rEtjN$UODrX1GY59l%!cR-9&uei#Bt_FJ=P^C;$Ke

delta 697
zcmZqDey+y1oR^o20SH1mS~J`DH}ZL~akBuq%|QHl8`I=Ows=)`kURvGaKKm$3?*QF
z5dIp*$<FMmmTWNDc(|StI18vl049&2dm+0jH$pe(<csWDZh4~03?(86Eh-E}9JTB<
z>?sUQOeqYt>~-wrjO7d!%#jS`jGPQL3|Vjkvf!33;GVpYNqBM`r>q2u0#2B*a0M!&
z6ls^8%+JNiC^=b@OHr1|Pm}Q$XK`|VL26oQUa}_dE#~5qq9RbZ7HLo3&Sl8O=~|JT
zT2PXipEp^Idoi~IP{s;~i`y9|AK}(u=3+IREXk8?(82NJF1N@B21ZsX1aX6pe?rIw
z4#^)t@PQd91*RD|1wU|1j^z!T9L<}jrwuf0ouj^!9K#`5MrT`wLvmbB2F!;vn4Pql
z4{5W4*apl%@x!)`T(0bsfADS+wg74=vIRMU8AvE7C=}UG-peP&>I~$CY`()cl}X_i
zM|^x<Vs2`D{4M63{PZF-kQP-Saf>;zprFWja*trJp#w+|r0Eu4W?phmX-aB*QGRJj
zYSBuDA{UUHJ&^dtVUwGmQks)$SCq9`K<E#XvM8g-3h@sNKng*8WM*KJxWXv@fe9pR
MG+AHNp9N$D09bdB5C8xG

diff --git a/src/logging.py b/src/logging.py
index a268c3e..a7f31af 100644
--- a/src/logging.py
+++ b/src/logging.py
@@ -54,7 +54,7 @@ class JSONFormatter(logging.Formatter):
             "funcName": record.funcName,
             "lineno": record.lineno,
             "pid": os.getpid(),
-            "request_id": request_id,
+            "request_id": request_id or "SYSTEM", # request id assigned per request or SYSTEM for system logs
         }
 
         
@@ -67,12 +67,13 @@ class JSONFormatter(logging.Formatter):
             log_record["stack_trace"] = self.formatStack(record.stack_info)
 
         # Add any extra attributes passed to the log call
-        # We skip standard attributes to avoid duplication
+        # We skip standard and internal uvicorn/fastapi attributes to avoid duplication or mess
         standard_attrs = {
             "args", "asctime", "created", "exc_info", "exc_text", "filename",
             "funcName", "levelname", "levelno", "lineno", "module", "msecs",
             "message", "msg", "name", "pathname", "process", "processName",
-            "relativeCreated", "stack_info", "thread", "threadName"
+            "relativeCreated", "stack_info", "thread", "threadName",
+            "color_message", "request", "scope"
         }
         for key, value in record.__dict__.items():
             if key not in standard_attrs:
diff --git a/src/main.py b/src/main.py
index fd54353..b5f803b 100644
--- a/src/main.py
+++ b/src/main.py
@@ -65,12 +65,15 @@ async def db_session_middleware(request: Request, call_next):
 
 
     try:
+        log.info(f"Incoming request: {request.method} {request.url.path}")
         session = async_scoped_session(async_session, scopefunc=get_request_id)
         request.state.db = session()
         collector_session = async_scoped_session(collector_async_session, scopefunc=get_request_id)
         request.state.collector_db = collector_session()
         response = await call_next(request)
+        log.info(f"Request completed: {response.status_code}")
     except Exception as e:
+        log.error(f"Request failed: {type(e).__name__} - {str(e)}")
         raise e from None
     finally:
         await request.state.db.close()